----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55132/#review162140 -----------------------------------------------------------
Hi Angela, Thank you for the corrections, I have two more findings based on the new diff file. Also, a committer also needs to check your change who is able to push it into the repo. Thanks, Bogi src/java/org/apache/sqoop/manager/Db2Manager.java (line 53) <https://reviews.apache.org/r/55132/#comment233400> Thanks for creating a constant for this, however, it would be great to check if there is already an enum or something for Hive data types and use it if so. src/test/com/cloudera/sqoop/ThirdPartyTests.java (lines 47 - 141) <https://reviews.apache.org/r/55132/#comment233401> Meanwhile this file has been removed by SQOOP-3099, be aware of this and make your change mergeable. - Boglarka Egyed On Jan. 13, 2017, 9:46 a.m., Ying Cao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55132/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2017, 9:46 a.m.) > > > Review request for Sqoop, Abraham Elmahrek and Jarek Cecho. > > > Bugs: SQOOP-1904 > https://issues.apache.org/jira/browse/SQOOP-1904 > > > Repository: sqoop-trunk > > > Description > ------- > > SQOOP-1904: support for DB2 XML data type when importing to hdfs > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/Db2Manager.java e39aa4c > src/test/com/cloudera/sqoop/ThirdPartyTests.java 7e10c68 > src/test/org/apache/sqoop/manager/db2/DB2XmlTypeImportManualTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/55132/diff/ > > > Testing > ------- > > UT passed by manually > > > Thanks, > > Ying Cao > >
