----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55132/#review162941 -----------------------------------------------------------
Hi Ying, I have one last minor finding, please correct it. Also, could you please open a documentation Jira ticket linked to the original one? I think this is an improvement which would be nice to document. Many thanks, Bogi src/java/org/apache/sqoop/manager/Db2Manager.java (line 53) <https://reviews.apache.org/r/55132/#comment234332> Just a little modification: could you please include the word "string" into the name too? It would me more clean e.g. as JAVA_STRING_DATA_TYPE or so. - Boglarka Egyed On Jan. 23, 2017, 6:17 a.m., Ying Cao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55132/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2017, 6:17 a.m.) > > > Review request for Sqoop, Abraham Elmahrek and Jarek Cecho. > > > Bugs: SQOOP-1904 > https://issues.apache.org/jira/browse/SQOOP-1904 > > > Repository: sqoop-trunk > > > Description > ------- > > SQOOP-1904: support for DB2 XML data type when importing to hdfs > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/Db2Manager.java e39aa4c > src/test/org/apache/sqoop/manager/db2/DB2XmlTypeImportManualTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/55132/diff/ > > > Testing > ------- > > UT passed by manually > > > Thanks, > > Ying Cao > >
