Github user itaifrenkel commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r18742240
--- Diff: storm-core/src/jvm/backtype/storm/spout/ShellSpout.java ---
@@ -56,13 +66,18 @@ public void open(Map stormConf, TopologyContext context,
_collector = collector;
_context = context;
+ workerTimeoutMills = 1000 *
RT.intCast(stormConf.get(Config.SUPERVISOR_WORKER_TIMEOUT_SECS));
+
_process = new ShellProcess(_command);
Number subpid = _process.launch(stormConf, context);
LOG.info("Launched subprocess with pid " + subpid);
+
+ heartBeatExecutor = new ScheduledThreadPoolExecutor(5);
--- End diff --
1. You should consult the comitters if they are happy with another thread,
or you are requested to use Tick tuples. A pro for another thread is the fact
that maybe maybe a multilang bolt would want to use tick tuples too. But
still...
2. 1 Thread should be enough.
3. This thread must not halt the process when main exists (as in tests), so
it should be daemonized. The way to do it AFAIK is this
heartBeanExecutor =
MoreExecutors.getExitingScheduledExecutorService(Executors.newScheduledThreadPool(1))
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
