Github user itaifrenkel commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r18745857
--- Diff: storm-core/src/jvm/backtype/storm/spout/ShellSpout.java ---
@@ -189,9 +207,53 @@ private void handleLog(ShellMsg shellMsg) {
@Override
public void activate() {
+ LOG.info("Start checking heartbeat...");
+ // prevent timer to check heartbeat based on last thing before
activate
+ setHeartbeat();
+ heartBeatExecutor.scheduleAtFixedRate(new
SpoutHeartbeatTimerTask(this), 1, 1, TimeUnit.SECONDS);
--- End diff --
When having a single thread there is not much difference between the two.
Even more your call back is non blocking so the difference is insignificant.
Nevertheless, even if it were entirley not accurate the code logic would stay
intact. There is nothing in that callback that warrants exactly one second.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
