Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/286#discussion_r18745292
--- Diff: storm-core/src/jvm/backtype/storm/spout/ShellSpout.java ---
@@ -56,13 +66,18 @@ public void open(Map stormConf, TopologyContext context,
_collector = collector;
_context = context;
+ workerTimeoutMills = 1000 *
RT.intCast(stormConf.get(Config.SUPERVISOR_WORKER_TIMEOUT_SECS));
+
_process = new ShellProcess(_command);
Number subpid = _process.launch(stormConf, context);
LOG.info("Launched subprocess with pid " + subpid);
+
+ heartBeatExecutor = new ScheduledThreadPoolExecutor(5);
--- End diff --
@itaifrenkel
1. AFAIK, ShellSpout's nextTuple() waits infinitely if subprocess is hang
(or doesn't send anything). That's what "sync" is for.
So we should check heartbeat with "new thread".
Please correct me if I'm wrong. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
