Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/305#discussion_r19839876
--- Diff: storm-core/src/jvm/backtype/storm/utils/ShellProcess.java ---
@@ -135,7 +135,14 @@ public void logErrorStream() {
public String getErrorsString() {
if (processErrorStream != null) {
try {
- return IOUtils.toString(processErrorStream);
+ StringBuilder sb = new StringBuilder();
+ while (processErrorStream.available() > 0) {
+ int bufferSize = processErrorStream.available();
--- End diff --
I'm curious to. Is it not safe because of chance of blocking, or
available() can always return 0 with some InputStream subclasses so we cannot
read any messages from subprocess?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
