Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/305#issuecomment-67989780
I see this has not had that much traffic in quite a while. The code to me
looks acceptable. I am not really happy with calling .available() twice, but I
can live with it. There is the possibility of a race if two different threads
call getErrorsString or logErrorStream at the same time, but as the way the
code is currently used that should not be a problem. I am +1 on checking this
in, but would like to know if others have any option.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
