Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/339#discussion_r21414360
--- Diff:
external/storm-kafka/src/jvm/storm/kafka/UpdateOffsetException.java ---
@@ -17,6 +17,9 @@
*/
package storm.kafka;
-public class UpdateOffsetException extends RuntimeException {
--- End diff --
I think UpdateOffsetException shouldn't extend FailedFetchException . They
meant to be different exceptions . The problem here is if a method throws
UpdateOffsetException and there is a catch for FailedFetchException its get
caught in that catch but we want to have different behavior for
FailedFetchException and UpdateOffsetException. Also UpdateOffsetException can
be named differently, may be TopicOffsetOutOfRangeException and for any other
errors use FailedFetchException.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
