Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/339#discussion_r21874150
--- Diff: external/storm-kafka/src/jvm/storm/kafka/KafkaUtils.java ---
@@ -155,7 +155,7 @@ public void refreshPartitions(Set<Partition>
partitions) {
}
}
- public static ByteBufferMessageSet fetchMessages(KafkaConfig config,
SimpleConsumer consumer, Partition partition, long offset) throws
UpdateOffsetException {
+ public static ByteBufferMessageSet fetchMessages(KafkaConfig config,
SimpleConsumer consumer, Partition partition, long offset) throws
TopicOffsetOutOfRangeException {
--- End diff --
Sorry I should've mention this earlier but can you add
FailedFetchException, RuntimeException to the throws class there. fetchMessages
throws above two apart from TopicOffsetOutOfRangeException but we only declare
one of the exception.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
