Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/339#discussion_r21495048
--- Diff:
external/storm-kafka/src/jvm/storm/kafka/UpdateOffsetException.java ---
@@ -17,6 +17,9 @@
*/
package storm.kafka;
-public class UpdateOffsetException extends RuntimeException {
--- End diff --
Renaming done. I feel TopicOffsetOutOfRangeException is just another cause
for a fetchFailedException so I created a "is a" relationship but on second
thoughts you are right. The caller will have a better experience if it had a
retriable and non retryable exception that it does not accidently handle in the
same catch block. Reverted back to using RunTimeException.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
