Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/374#discussion_r24041005
--- Diff:
external/storm-jdbc/src/main/java/org/apache/storm/jdbc/common/JdbcClient.java
---
@@ -0,0 +1,213 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.jdbc.common;
+
+import com.google.common.base.Function;
+import com.google.common.base.Joiner;
+import com.google.common.collect.Collections2;
+import com.google.common.collect.Lists;
+import com.zaxxer.hikari.HikariConfig;
+import com.zaxxer.hikari.HikariDataSource;
+import org.apache.commons.lang.StringUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.sql.*;
+import java.sql.Date;
+import java.util.*;
+
+public class JdbcClient {
+ private static final Logger LOG =
LoggerFactory.getLogger(JdbcClient.class);
+
+ private HikariDataSource dataSource;
+ private int queryTimeoutSecs;
+
+ public JdbcClient(Map<String, Object> map, int queryTimeoutSecs) {
+ Properties properties = new Properties();
+ properties.putAll(map);
+ HikariConfig config = new HikariConfig(properties);
+ this.dataSource = new HikariDataSource(config);
+ this.queryTimeoutSecs = queryTimeoutSecs;
+ }
+
+ public int insert(String tableName, List<List<Column>> columnLists) {
+ Connection connection = null;
+ try {
+ connection = this.dataSource.getConnection();
+ StringBuilder sb = new StringBuilder();
+ sb.append("Insert into ").append(tableName).append(" (");
+ Collection<String> columnNames =
Collections2.transform(columnLists.get(0), new Function<Column, String>() {
+ @Override
+ public String apply(Column input) {
+ return input.getColumnName();
+ }
+ });
+ String columns = Joiner.on(",").join(columnNames);
+ sb.append(columns).append(") values ( ");
+
+ String placeHolders =
StringUtils.chop(StringUtils.repeat("?,", columnNames.size()));
+ sb.append(placeHolders).append(")");
--- End diff --
We are using prepared statements with place holders so we are leveraging
the statement cache., not sure if you mean something else by "JDBC stored
queries". The statement cache is generally on server side and as long as we are
using preparedstatements with place holders "?" we should get the benefit of
not having to compile/parse the sql and the cached execution plan.
The only reason we construct the sql query each time is because this is
more flexible then a single static sql. For inserts people can have columns
with default values and their topology can chose to emit values for those
columns sometimes and sometimes they can just ignore those columns and both
scenarios will be supported.
I can provide an override sql that user can provide , personally I would
rather wait till we actually come across a DB or user that runs into some issue
before adding that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
