Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/374#discussion_r24430530
--- Diff:
external/storm-jdbc/src/main/java/org/apache/storm/jdbc/bolt/JdbcInsertBolt.java
---
@@ -0,0 +1,79 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.jdbc.bolt;
+import backtype.storm.topology.OutputFieldsDeclarer;
+import backtype.storm.tuple.Tuple;
+import org.apache.storm.jdbc.common.Column;
+import org.apache.storm.jdbc.mapper.JdbcMapper;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Basic bolt for writing to any Database table.
+ * <p/>
+ * Note: Each JdbcInsertBolt defined in a topology is tied to a specific
table.
+ */
+public class JdbcInsertBolt extends AbstractJdbcBolt {
+ private static final Logger LOG =
LoggerFactory.getLogger(JdbcInsertBolt.class);
+
+ private String tableName;
+ private JdbcMapper jdbcMapper;
+
+ public JdbcInsertBolt(String configKey) {
+ super(configKey);
+ }
+
+ public JdbcInsertBolt withTableName(String tableName) {
+ this.tableName = tableName;
+ return this;
+ }
+
+ public JdbcInsertBolt withJdbcMapper(JdbcMapper jdbcMapper) {
+ this.jdbcMapper = jdbcMapper;
+ return this;
+ }
+
+ public JdbcInsertBolt withQueryTimeoutSecs(int queryTimeoutSecs) {
+ this.queryTimeoutSecs = queryTimeoutSecs;
+ return this;
+ }
+
+ @Override
+ public void execute(Tuple tuple) {
+ try {
+ List<Column> columns = jdbcMapper.getColumns(tuple);
+ List<List<Column>> columnLists = new ArrayList<List<Column>>();
+ columnLists.add(columns);
+ this.jdbcClient.insert(this.tableName, columnLists);
--- End diff --
For me the issue is with required configuration vs optional configuration.
configKey is not the only required configuration. table name and jdbcMapper
both appear to be required in the current code. I would much rather have them
be parameters to the constructor instead of builder methods, or have a
reasonable default set in the constructor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
