Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/556#discussion_r31087238
--- Diff: external/storm-jdbc/README.md ---
@@ -17,11 +44,12 @@ The `getColumns()` method defines how a storm tuple
maps to a list of columns re
**The order of the returned list is important. The place holders in the
supplied queries are resolved in the same order as returned list.**
For example if the user supplied insert query is `insert into
user(user_id, user_name, create_date) values (?,?, now())` the 1st item
of the returned list of `getColumns` method will map to the 1st place
holder and the 2nd to the 2nd and so on. We do not parse
-the supplied queries to try and resolve place holder by column names.
+the supplied queries to try and resolve place holder by column names. Not
making any assumptions about the query syntax allows this connector
+to be used by some non-standard sql frameworks like Pheonix which only
supports upsert into.
### JdbcInsertBolt
-To use the `JdbcInsertBolt`, you construct an instance of it and specify a
configuration key in your storm config that holds the
-hikari configuration map and a `JdbcMapper` implementation that coverts
storm tuple to DB row. In addition, you must either supply
+To use the `JdbcInsertBolt`, you construct an instance of it by specifying
a `ConnectionProvider` implementation
+and a `JdbcMapper` implementation that coverts storm tuple to DB row. In
addition, you must either supply
--- End diff --
coverts -> converts
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
