Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/556#discussion_r31087884
--- Diff:
external/storm-jdbc/src/main/java/org/apache/storm/jdbc/mapper/SimpleJdbcMapper.java
---
@@ -33,9 +34,10 @@
private List<Column> schemaColumns;
- public SimpleJdbcMapper(String tableName, Map hikariConfigurationMap) {
+ public SimpleJdbcMapper(String tableName, Map<String, Object>
connectionProvideConfig, ConnectionProvider connectionProvider) {
--- End diff --
Seems like we don't need to connectionProvideConfig here for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
