Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/556#discussion_r31087567
--- Diff: external/storm-jdbc/README.md ---
@@ -29,13 +57,21 @@ The default is set to value of
topology.message.timeout.secs and a value of -1 w
You should set the query timeout value to be <=
topology.message.timeout.secs.
```java
-Config config = new Config();
-config.put("jdbc.conf", hikariConfigMap);
-JdbcInsertBolt userPersistanceBolt = new
JdbcInsertBolt("jdbc.conf",simpleJdbcMapper)
+Map hikariConfigMap = Maps.newHashMap();
--- End diff --
minor thing:
How about changing this line to
```
Map<String, String> hikariConfigMap = new HashMap<String, String>();
```
to remove dependency about Guava from example?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
