Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r40730329
--- Diff: storm-core/src/jvm/backtype/storm/StormSubmitter.java ---
@@ -187,7 +187,7 @@ public static void submitTopology(String name, Map
stormConf, StormTopology topo
* @throws AuthorizationException
*/
--- End diff --
If we now throw an IllegalArgumentException, even if it is a Runtime
Exception we should document it here, and ideally describe the situation when
it is thrown. Otherwise why declare it at all?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
