Github user jerrypeng commented on a diff in the pull request:

    https://github.com/apache/storm/pull/746#discussion_r40731631
  
    --- Diff: storm-core/src/jvm/backtype/storm/Config.java ---
    @@ -1101,6 +1127,33 @@
         public static final Object TOPOLOGY_TASKS_SCHEMA = 
ConfigValidation.IntegerValidator;
     
         /**
    +     * The maximum amount of memory an instance of a spout/bolt will take 
on heap. This enables the scheduler
    +     * to allocate slots on machines with enough available memory.
    +     */
    +    public static final String 
TOPOLOGY_COMPONENT_RESOURCES_ONHEAP_MEMORY_MB = 
"topology.component.resources.onheap.memory.mb";
    +    public static final Object 
TOPOLOGY_COMPONENT_RESOURCES_ONHEAP_MEMORY_MB_SCHEMA = 
ConfigValidation.NonNegativeNumberValidator;
    +
    +    /**
    +     * The maximum amount of memory an instance of a spout/bolt will take 
off heap. This enables the scheduler
    +     * to allocate slots on machines with enough available memory.
    +     */
    +    public static final String 
TOPOLOGY_COMPONENT_RESOURCES_OFFHEAP_MEMORY_MB = 
"topology.component.resources.offheap.memory.mb";
    +    public static final Object 
TOPOLOGY_COMPONENT_RESOURCES_OFFHEAP_MEMORY_MB_SCHEMA = 
ConfigValidation.NonNegativeNumberValidator;
    +
    +    /**
    +     * The config indicates the percentage of cpu for a core. Assuming the 
a core value to be 100, a
    --- End diff --
    
    will fix comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to