Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/746#discussion_r40731800
  
    --- Diff: storm-core/src/jvm/backtype/storm/scheduler/Topologies.java ---
    @@ -21,10 +21,17 @@
     import java.util.HashMap;
     import java.util.Map;
     
    +import backtype.storm.scheduler.resource.RAS_Component;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
     public class Topologies {
         Map<String, TopologyDetails> topologies;
         Map<String, String> nameToId;
    -    
    +    Map<String, Map<String, RAS_Component>> _allRAS_Components;
    +
    +    private static final Logger LOG = 
LoggerFactory.getLogger(Topologies.class);
    --- End diff --
    
    This does not look like it is being used.  Not a big deal, but unless we 
use it we should probably remove it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to