Github user redsanket commented on a diff in the pull request:

    https://github.com/apache/storm/pull/845#discussion_r44998736
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj ---
    @@ -326,16 +331,29 @@
                                              (log-error t "Error when 
processing event")
                                              (exit-process! 20 "Error when 
processing an event")
                                              ))
    +   :blob-update-timer (mk-timer :kill-fn (fn [t]
    +                                           (log-error t "Error when 
processing blob-update")
    +                                           (exit-process! 20 "Error when 
processing a blob-update")
    --- End diff --
    
    it would make it more clear but i guess in order to keep it consistent with 
other's we might want to change it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to