Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45106444
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/SyncBlobs.java ---
@@ -0,0 +1,132 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package backtype.storm.blobstore;
+
+import backtype.storm.nimbus.NimbusInfo;
+import backtype.storm.utils.Utils;
+import org.apache.curator.framework.CuratorFramework;
+import org.apache.thrift.transport.TTransportException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.List;
+import java.util.ArrayList;
+import java.util.Map;
+
+/**
+ * Is called periodically and updates the nimbus with blobs based on the
state stored inside the zookeeper
+ */
+public class SyncBlobs {
+ private static final Logger LOG =
LoggerFactory.getLogger(SyncBlobs.class);
+ private CuratorFramework zkClient;
+ private Map conf;
+ private BlobStore blobStore;
+ private List<String> blobStoreKeyList = new ArrayList<String>();
+ private List<String> zookeeperKeyList = new ArrayList<String>();
+ private NimbusInfo nimbusInfo;
+
+ public SyncBlobs(BlobStore blobStore, Map conf) {
+ this.blobStore = blobStore;
+ this.conf = conf;
+ }
+
+ public void setNimbusInfo(NimbusInfo nimbusInfo) {
+ this.nimbusInfo = nimbusInfo;
+ }
+
+ public void setZookeeperKeyList(List<String> zookeeperKeyList) {
+ this.zookeeperKeyList = zookeeperKeyList;
+ }
+
+ public void setBlobStoreKeyList(List<String> blobStoreKeyList) {
+ this.blobStoreKeyList = blobStoreKeyList;
+ }
+
+ public NimbusInfo getNimbusInfo() {
+ return nimbusInfo;
+ }
+
+ public List<String> getBlobStoreKeyList() {
+ List<String> keyList = new ArrayList<String>();
+ keyList.addAll(blobStoreKeyList);
+ return keyList;
+ }
--- End diff --
Lists might be the wrong data structure here. They do not have to be
ordered, but they cannot have duplicates. Maybe we want Set here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
