Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45102927
--- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj ---
@@ -1206,22 +1328,40 @@
(.set_reset_log_level_timeout_epoch log-config (coerce/to-long
timeout))
(.unset_reset_log_level_timeout_epoch log-config))))
+(defmethod blob-sync-code :distributed [conf nimbus]
+ (if (not (is-leader nimbus :throw-exception false))
+ (let [storm-cluster-state (:storm-cluster-state nimbus)
+ nimbus-host-port-info (:nimbus-host-port-info nimbus)
+ blob-store-key-list (into [] (get-key-seq-from-blob-store
(:blob-store nimbus)))
+ zk-key-list (into [] (.blobstore storm-cluster-state (fn []
(blob-sync-code conf nimbus))))]
+ (log-debug "blob-sync-code " "blob-store-keys " blob-store-key-list
"zookeeper-keys " zk-key-list)
+ (let [sync-blobs (doto
+ (SyncBlobs. (:blob-store nimbus) conf)
+ (.setNimbusInfo nimbus-host-port-info)
+ (.setBlobStoreKeyList (if (not-nil?
blob-store-key-list) (ArrayList. blob-store-key-list) (ArrayList.)))
+ (.setZookeeperKeyList (if (not-nil? zk-key-list)
(ArrayList. zk-key-list) (ArrayList.))))]
--- End diff --
Do we need to send `ArrayList`s specifically when calling
`setBlobStoreKeyList` and `setZookeeperKeyList`, or can we say something like
`(or blob-store-key-list [])`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
