[
https://issues.apache.org/jira/browse/STORM-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15057369#comment-15057369
]
ASF GitHub Bot commented on STORM-1038:
---------------------------------------
Github user hsun-cnnxty commented on a diff in the pull request:
https://github.com/apache/storm/pull/728#discussion_r47597958
--- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java ---
@@ -182,7 +177,7 @@ private boolean connectionEstablished(Channel channel) {
// See:
// -
http://netty.io/3.9/api/org/jboss/netty/channel/ChannelEvent.html
// -
http://stackoverflow.com/questions/13356622/what-are-the-netty-channel-state-transitions
- return channel != null && channel.isConnected();
+ return channel != null && channel.isOpen();
--- End diff --
Thanks for the code review. It could be a bug. Netty 4.x has simplified the
state model. See
http://netty.io/wiki/new-and-noteworthy-in-4.0.html#wiki-h4-19
So channelOpen, channelBound, and channelConnected have been merged to
channelActive and Channel.isBound() and isConnected() have been merged to
isActive(). The isConnected() method is removed. I think I should use
isActive() instead of isOpen(). The code comments need update too. I will fix
it and other format issues this weekend if I get time.
> Upgrade netty transport from 3.x to 4.x
> ---------------------------------------
>
> Key: STORM-1038
> URL: https://issues.apache.org/jira/browse/STORM-1038
> Project: Apache Storm
> Issue Type: Dependency upgrade
> Components: storm-core
> Reporter: Hang Sun
> Priority: Minor
> Labels: performance
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> It will be nice to upgrade netty to 4.x to take advantage of its more
> efficient memory usage.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
