[
https://issues.apache.org/jira/browse/STORM-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089777#comment-15089777
]
ASF GitHub Bot commented on STORM-1038:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/728#discussion_r49227209
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/KerberosSaslClientHandler.java
---
@@ -46,56 +44,48 @@ public KerberosSaslClientHandler(ISaslClient client,
Map storm_conf, String jaas
}
@Override
- public void channelConnected(ChannelHandlerContext ctx,
- ChannelStateEvent event) {
+ public void channelActive(ChannelHandlerContext ctx) throws Exception {
// register the newly established channel
- Channel channel = ctx.getChannel();
- client.channelConnected(channel);
+ Channel channel = ctx.channel();
+ client.channelReady();
LOG.info("Connection established from {} to {}",
- channel.getLocalAddress(), channel.getRemoteAddress());
+ channel.localAddress(), channel.localAddress());
--- End diff --
I don't think channel.getRemoteAddress and channel.localAddress return the
same thing.
> Upgrade netty transport from 3.x to 4.x
> ---------------------------------------
>
> Key: STORM-1038
> URL: https://issues.apache.org/jira/browse/STORM-1038
> Project: Apache Storm
> Issue Type: Dependency upgrade
> Components: storm-core
> Reporter: Hang Sun
> Priority: Minor
> Labels: performance
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> It will be nice to upgrade netty to 4.x to take advantage of its more
> efficient memory usage.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
