[
https://issues.apache.org/jira/browse/STORM-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089780#comment-15089780
]
ASF GitHub Bot commented on STORM-1038:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/728#discussion_r49227426
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/NettyUncaughtExceptionHandler.java
---
@@ -21,6 +21,24 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+/*
+public class StormClientErrorHandler extends ChannelInboundHandlerAdapter {
+ private static final Logger LOG =
LoggerFactory.getLogger(StormClientErrorHandler.class);
+ private String name;
+
+ StormClientErrorHandler(String name) {
+ this.name = name;
+ }
+
+ @Override
+ public void exceptionCaught(ChannelHandlerContext ctx, Throwable
cause) throws Exception {
+ if (!(cause instanceof ConnectException)) {
+ LOG.info("Connection failed " + name, cause);
+ }
+ }
+}
+*/
+
--- End diff --
We should delete this commented out code.
> Upgrade netty transport from 3.x to 4.x
> ---------------------------------------
>
> Key: STORM-1038
> URL: https://issues.apache.org/jira/browse/STORM-1038
> Project: Apache Storm
> Issue Type: Dependency upgrade
> Components: storm-core
> Reporter: Hang Sun
> Priority: Minor
> Labels: performance
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> It will be nice to upgrade netty to 4.x to take advantage of its more
> efficient memory usage.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
