Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1074#discussion_r52215149
  
    --- Diff: storm-core/src/jvm/org/apache/storm/utils/Time.java ---
    @@ -98,10 +104,25 @@ public static long currentTimeMillis() {
                 return System.currentTimeMillis();
             }
         }
    -    
    +
    +    public static long toMillis (int secs) {
    +        return 1000*(long) secs;
    +    }
    +    public static long toMillis (String secs) {
    --- End diff --
    
    This is even less obvious that it is seconds to millis,  and who is calling 
this anyways?  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to