Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1074#discussion_r52216050
  
    --- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
    @@ -106,8 +158,23 @@
     
         public static Object newInstance(String klass) {
             try {
    -            Class c = Class.forName(klass);
    -            return c.newInstance();
    +            LOG.info("Creating new instance for class {}", klass);
    +            return newInstance(Class.forName(klass));
    +        } catch (Exception e) {
    +            throw new RuntimeException(e);
    +        }
    +    }
    +
    +    public static Object newInstance(Class klass) {
    +        LOG.info("Inside other newInstance static method.");
    +        return _instance.newInstanceImpl(klass);
    +    }
    +
    +    // Non-static impl methods exist for mocking purposes.
    +    public Object newInstanceImpl(Class klass) {
    +        try {
    +            LOG.info("Returning {}.newInstance()", klass);
    --- End diff --
    
    Please remove or make debug


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to