Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1074#discussion_r52216501
  
    --- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
    @@ -580,20 +655,23 @@ public static void restrictPermissions(String 
baseDir) {
         }
     
     
    -    public static synchronized IFn loadClojureFn(String namespace, String 
name) {
    +    public static synchronized clojure.lang.IFn loadClojureFn(String 
namespace, String name) {
             try {
                 clojure.lang.Compiler.eval(RT.readString("(require '" + 
namespace + ")"));
             } catch (Exception e) {
                 //if playing from the repl and defining functions, file won't 
exist
             }
    -        return (IFn) RT.var(namespace, name).deref();
    +        return (clojure.lang.IFn) RT.var(namespace, name).deref();
         }
     
         public static boolean isSystemId(String id) {
             return id.startsWith("__");
         }
     
    -    public static <K, V> Map<V, K> reverseMap(Map<K, V> map) {
    +    /*
    +        TODO: Can this be replaced with reverseMap in this file?
    --- End diff --
    
    Does not look like it can.  The return types are completely different.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to