[jira] [Commented] (STORM-1574) Better exception handling in backpressure thread, and remove backpressure dir during topology kill.

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/STORM-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15167291#comment-15167291
 ] 

ASF GitHub Bot commented on STORM-1574:
---------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1149#discussion_r54107946
  
    --- Diff: 
storm-core/src/jvm/org/apache/storm/utils/WorkerBackpressureThread.java ---
    @@ -43,17 +48,33 @@ static public void notifyBackpressureChecker(Object 
trigger) {
             }
         }
     
    +    public void terminate() {
    +        running = false;
    +    }
    --- End diff --
    
    We could then ignore the interrupted exception in run as it would just be 
used as a trigger to wake up the running thread.


> Better exception handling in backpressure thread, and remove backpressure dir 
> during topology kill.
> ---------------------------------------------------------------------------------------------------
>
>                 Key: STORM-1574
>                 URL: https://issues.apache.org/jira/browse/STORM-1574
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-core
>    Affects Versions: 1.0.0, 2.0.0
>            Reporter: Zhuo Liu
>            Assignee: Zhuo Liu
>             Fix For: 1.0.0, 2.0.0
>
>
> The current exception handling in WorkerBackpressureThread can cause the 
> thread to die before we want, causing potential backpressure flag 
> synchronizing problem. 
> Also, we need to cleanup the topology backpressure directory during killing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)