[
https://issues.apache.org/jira/browse/STORM-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15167967#comment-15167967
]
ASF GitHub Bot commented on STORM-1574:
---------------------------------------
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1149#discussion_r54172980
--- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj ---
@@ -155,7 +155,10 @@
;; update the worker's backpressure flag to zookeeper only when it
has changed
(log-debug "BP " @(:backpressure worker) " WAS "
prev-backpressure-flag)
(when (not= prev-backpressure-flag @(:backpressure worker))
- (.workerBackpressure storm-cluster-state storm-id assignment-id
port @(:backpressure worker)))
+ (try
+ (.workerBackpressure storm-cluster-state storm-id
assignment-id (long port) @(:backpressure worker))
--- End diff --
(:port worker) returns an Integer. Will cause an exception if not turning
to long. See also Storm-1578.
> Better exception handling in backpressure thread, and remove backpressure dir
> during topology kill.
> ---------------------------------------------------------------------------------------------------
>
> Key: STORM-1574
> URL: https://issues.apache.org/jira/browse/STORM-1574
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Affects Versions: 1.0.0, 2.0.0
> Reporter: Zhuo Liu
> Assignee: Zhuo Liu
> Fix For: 1.0.0, 2.0.0
>
>
> The current exception handling in WorkerBackpressureThread can cause the
> thread to die before we want, causing potential backpressure flag
> synchronizing problem.
> Also, we need to cleanup the topology backpressure directory during killing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
