[ https://issues.apache.org/jira/browse/STORM-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15167651#comment-15167651 ]
ASF GitHub Bot commented on STORM-1574: --------------------------------------- Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1149#issuecomment-188931704 The changes look good, but I would like to see the tests updated still. I am not sure if they will still pass without some changes. Specifically around the uncaught exception handler. It would be nice to have an API so we can mock that out. > Better exception handling in backpressure thread, and remove backpressure dir > during topology kill. > --------------------------------------------------------------------------------------------------- > > Key: STORM-1574 > URL: https://issues.apache.org/jira/browse/STORM-1574 > Project: Apache Storm > Issue Type: Improvement > Components: storm-core > Affects Versions: 1.0.0, 2.0.0 > Reporter: Zhuo Liu > Assignee: Zhuo Liu > Fix For: 1.0.0, 2.0.0 > > > The current exception handling in WorkerBackpressureThread can cause the > thread to die before we want, causing potential backpressure flag > synchronizing problem. > Also, we need to cleanup the topology backpressure directory during killing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)