Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/1131#issuecomment-197979792
@revans2 @abhishekagarwal87 I am still going over all your comments and I
will think through them thoroughly and I am welcome to incorporate everything
that makes this better. However, one thing I would like to suggest is that we
try to gather requirements and identify the best possible solution for all of
those requirements, rather than simply trying to fit some of the existing
KafkaSpout's solutions into this KafkaSpout. There are a lot of design
decisions I don't agree with in the previous KafkaSpout that among other things
made the code very complex and verbose. We should use the previous code to
identify requirements, but we shouldn't simply follow it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
