Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r56466552
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaRecordTupleBuilder.java
---
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.kafka.spout;
+
+import org.apache.kafka.clients.consumer.ConsumerRecord;
+import org.apache.storm.tuple.Fields;
+import org.apache.storm.tuple.Values;
+
+import java.util.List;
+
+public class KafkaRecordTupleBuilder<K, V> implements
KafkaSpoutTupleBuilder<K, V> {
+ @Override
+ public List<Object> buildTuple(final ConsumerRecord<K, V>
consumerRecord, KafkaSpoutStreams kafkaSpoutStreams) {
--- End diff --
@abhishekagarwal87 I disagree. The schema is a subset of the output fields,
which are "in a sense" part of the stream definition. To build a tuple, one
may or may not need access to the output fields information (in the example I
provide this info is only used the count the num of output fields).
This information is available in the `KafkaSpoutStreams` "stream
definition" object, and makes no sense to be passing it around in a different
object for several reasons.
1. Redundancy.
2. It is easier to make mistakes that cannot be found at compile time (e.g.
using a field in the schema that does not exist in the output fields)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
