Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1665#discussion_r77106883
--- Diff:
external/storm-kafka-monitor/src/main/java/org/apache/storm/kafka/monitor/KafkaOffsetLagUtil.java
---
@@ -89,6 +89,10 @@ public static void main (String args[]) {
printUsageAndExit(options, OPTION_ZK_SERVERS_LONG + "
and " + OPTION_ZK_COMMITTED_NODE_LONG + " are required with " +
OPTION_OLD_CONSUMER_LONG);
}
+ String zkNode =
commandLine.getOptionValue(OPTION_ZK_COMMITTED_NODE_LONG);
--- End diff --
`zkNode == null` is not unnecessary since `hasArg` is set to true. and I
will remove.
but `zkNode.length() <= 1` is necessary because zkPath should start with
`/`, so the valid path length should `> 1`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
