Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1665#discussion_r77107687
--- Diff:
external/storm-kafka-monitor/src/main/java/org/apache/storm/kafka/monitor/KafkaOffsetLagUtil.java
---
@@ -373,16 +377,20 @@ private static Options buildOptions () {
curatorFramework.start();
String partitionPrefix = "partition_";
String zkPath = oldKafkaSpoutOffsetQuery.getZkPath();
- if (!zkPath.endsWith("/")) {
- zkPath += "/";
+ if (zkPath.endsWith("/")) {
--- End diff --
I think it is better to check the variable before use it. and the zkPath
must not ends with `/`.
the `printUsageAndExit` method needs argument `Options` which is not
available in `getOldConsumerOffsetsFromZk`. so I use `exit` directly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
