Github user priyank5485 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1665#discussion_r77237088
--- Diff:
external/storm-kafka-monitor/src/main/java/org/apache/storm/kafka/monitor/KafkaOffsetLagUtil.java
---
@@ -89,6 +89,10 @@ public static void main (String args[]) {
printUsageAndExit(options, OPTION_ZK_SERVERS_LONG + "
and " + OPTION_ZK_COMMITTED_NODE_LONG + " are required with " +
OPTION_OLD_CONSUMER_LONG);
}
+ String zkNode =
commandLine.getOptionValue(OPTION_ZK_COMMITTED_NODE_LONG);
--- End diff --
I am not sure if just checking the length <= 1 is really that useful. As
you mentioned that it should start with / may be we add check satisfying all
the conditions for a valid zookeeper node name? Or just remove any check? We
already have a check to see if node exists later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
