Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r99635403
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -78,7 +78,7 @@
private transient Map<TopicPartition, OffsetManager> acked;
// Tuples that were successfully acked. These tuples will be committed
periodically when the commit timer expires, after consumer rebalance, or on
close/deactivate
private transient Set<KafkaSpoutMessageId> emitted; //
Tuples that have been emitted but that are "on the wire", i.e. pending being
acked or failed
private transient Iterator<ConsumerRecord<K, V>> waitingToEmit;
// Records that have been polled and are queued to be emitted in the
nextTuple() call. One record is emitted per nextTuple()
- private transient long numUncommittedOffsets; //
Number of offsets that have been polled and emitted but not yet been committed
+ private transient int numUncommittedOffsets; //
Number of offsets that have been polled and emitted but not yet been committed
--- End diff --
Why impose a more restricted data type? What if the user desires a large
number?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
