Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r99640360
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -240,7 +240,9 @@ private boolean commit() {
private boolean poll() {
final int maxUncommittedOffsets =
kafkaSpoutConfig.getMaxUncommittedOffsets();
- final boolean poll = !waitingToEmit() && numUncommittedOffsets <
maxUncommittedOffsets;
+ final boolean poll = !waitingToEmit() &&
+ (numUncommittedOffsets < maxUncommittedOffsets ||
+ !retryService.retriableTopicPartitions().isEmpty());
--- End diff --
`!retryService.retriableTopicPartitions().isEmpty()` can't this condition
cause unbounded polling (i.e. continue forever), if some specific tuples are
always failing?
The goal is to have a limit in how much can be polled (hence kept in
memory) in case of recurring failures.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
