Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r99641026
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -289,6 +293,13 @@ private void doSeekRetriableTopicPartitions() {
kafkaConsumer.seek(rtp,
acked.get(rtp).getCommittedOffset() + 1); // Seek to last committed offset
}
}
+
+ if(!retriableTopicPartitions.isEmpty()) {
+ //Pause other partitions for this poll so
maxUncommittedPartitions isn't exceeded by too much
--- End diff --
I am a bit confused about this. When can it be exceeded? By how much? This
should be a deterministic number.
I read your comment in the email thread about maxSpoutPending. Is this
related to that ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
