Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r99932405
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -329,11 +328,13 @@ private Builder(Builder<?, ?> builder,
SerializableDeserializer<K> keyDes, Class
this.offsetCommitPeriodMs = offsetCommitPeriodMs;
return this;
}
-
+
/**
* Defines the max number of polled offsets (records) that can be
pending commit, before another poll can take place.
* Once this limit is reached, no more offsets (records) can be
polled until the next successful commit(s) sets the number
- * of pending offsets bellow the threshold. The default is {@link
#DEFAULT_MAX_UNCOMMITTED_OFFSETS}.
+ * of pending offsets below the threshold. The default is {@link
#DEFAULT_MAX_UNCOMMITTED_OFFSETS}.
+ * Note that this limit can in some cases be exceeded, but no
partition will exceed this limit by more than 2*maxPollRecords.
--- End diff --
Agree
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
