Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2147#discussion_r119404574
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -170,10 +182,13 @@ private void initialize(Collection<TopicPartition>
partitions) {
final long fetchOffset = doSeek(tp, committedOffset);
setAcked(tp, fetchOffset);
}
- initialized = true;
+
+ task.start();
--- End diff --
Since this is invoked from `onPartitionsAssigned`, the isComplete is going
to return true as soon as onPartitionsRevoked is invoked after partition
assignment right ?
The `onPartitionsRevoked` could wait for message.timeout.secs so that
in-flight messages are acked/failed and then commit the offsets before
returning to minimize the duplicates. May be this is what you wanted the
ConsumerRebalanceHandlerTask to handle via isCompleted but it does not seem to
do that currently.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
