Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2147#discussion_r119421827
--- Diff:
examples/storm-kafka-examples/src/main/java/org/apache/storm/kafka/trident/KafkaProducerTopology.java
---
@@ -54,7 +54,7 @@ public static StormTopology newTopology(String brokerUrl,
String topicName) {
/**
* @return the Storm config for the topology that publishes sentences
to kafka using a kafka bolt.
*/
- private static Properties newProps(final String brokerUrl, final
String topicName) {
+ static Properties newProps(final String brokerUrl, final String
topicName) {
--- End diff --
I use this for some test cases I have I use that are not part of the
codebase. This is not a change as it's left as package protected
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
