Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2147#discussion_r119420992
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -252,14 +289,16 @@ private boolean commit() {
private boolean poll() {
final int maxUncommittedOffsets =
kafkaSpoutConfig.getMaxUncommittedOffsets();
final int readyMessageCount = retryService.readyMessageCount();
- final boolean poll = !waitingToEmit() &&
- //Check that the number of uncommitted, nonretriable tuples is
less than the maxUncommittedOffsets limit
- //Accounting for retriable tuples this way still guarantees
that the limit is followed on a per partition basis, and prevents locking up
the spout when there are too many retriable tuples
- (numUncommittedOffsets - readyMessageCount <
maxUncommittedOffsets ||
- consumerAutoCommitMode);
+ final boolean poll = !isWaitingToEmit() &&
+ /*
+ * Check that the number of uncommitted, non-retriable
tuples is less than the maxUncommittedOffsets limit
+ * Accounting for retriable tuples this way still guarantees
that the limit is followed on a per partition basis,
+ * and prevents locking up the spout when there are too many
retriable tuples
+ */
+ (numUncommittedOffsets - readyMessageCount <
maxUncommittedOffsets || consumerAutoCommitMode);
--- End diff --
Will do, but this was pre-existing code, not really pertaining to the scope
of this patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
