Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2147#discussion_r119429686
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -170,10 +182,13 @@ private void initialize(Collection<TopicPartition>
partitions) {
final long fetchOffset = doSeek(tp, committedOffset);
setAcked(tp, fetchOffset);
}
- initialized = true;
+
+ task.start();
--- End diff --
I believe @srdo says is true. Once a rebalance happens, I don't think
commits can be done to kafka. The purpose of the onPartitionsRevoked callback
is to handle persisting offsets in a separate storage.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
