Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129496179 --- Diff: conf/defaults.yaml --- @@ -231,16 +228,13 @@ topology.multilang.serializer: "org.apache.storm.multilang.JsonSerializer" topology.shellbolt.max.pending: 100 topology.skip.missing.kryo.registrations: false topology.max.task.parallelism: null -topology.max.spout.pending: null +topology.max.spout.pending: null # TODO: We dont need this any more topology.state.synchronization.timeout.secs: 60 -topology.stats.sample.rate: 0.05 +topology.stats.sample.rate: 0.001 --- End diff -- Is the change intended? This is OK to change it while doing performance test (especially micro perf), but 0.1% might be too small for production. Even users complained that only 5% of tuples are measured. Other frameworks using dropwizard metrics even don't sample for meters, and I guess we will follow the rule on new metrics.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---