Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129536804 --- Diff: storm-client/src/jvm/org/apache/storm/grouping/ShuffleGrouping.java --- @@ -26,38 +26,25 @@ import java.util.ArrayList; import java.util.Arrays; import java.util.Collections; -import java.util.concurrent.atomic.AtomicInteger; + public class ShuffleGrouping implements CustomStreamGrouping, Serializable { - private Random random; private ArrayList<List<Integer>> choices; - private AtomicInteger current; + private int current = 0 ; --- End diff -- `chooseTasks` is implemented based on the assumption of thread safety, so we should check this again. If it's thread-safe, it is better to leave comment on this.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---