Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129504947
--- Diff: examples/storm-perf/pom.xml ---
@@ -81,7 +81,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
- <maxAllowedViolations>207</maxAllowedViolations>
+ <maxAllowedViolations>407</maxAllowedViolations>
--- End diff --
Just leaving a note: ideally it should be set to lower, not higher. OK to
address it by end of reviewing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
