Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2319#discussion_r138071918
  
    --- Diff: storm-core/pom.xml ---
    @@ -331,6 +331,10 @@
                 <artifactId>commons-codec</artifactId>
             </dependency>
             <dependency>
    +            <groupId>org.rocksdb</groupId>
    +            <artifactId>rocksdbjni</artifactId>
    +        </dependency>
    --- End diff --
    
    I am sorry to say that this is not a rolling upgrade.  This can only go 
into 2.x+ with rocksdbjni.  rocksdbjni is based off of jni as the name suggests 
so it cannot be shaded, and it is a common enough library that I am concerned 
that it will cause conflicts with many others when it shows up on the worker 
classpath.
    
    It is also a library that changes very quickly, so it is not simple to pick 
a version that is likely to work for everyone. 


---

Reply via email to