Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138073574
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -62,26 +63,17 @@
(defn- assignments-snapshot [storm-cluster-state callback
assignment-versions]
(let [storm-ids (.assignments storm-cluster-state callback)]
- (let [new-assignments
- (->>
- (dofor [sid storm-ids]
- (let [recorded-version (:version (get
assignment-versions sid))]
- (if-let [assignment-version (.assignment-version
storm-cluster-state sid callback)]
- (if (= assignment-version recorded-version)
- {sid (get assignment-versions sid)}
- {sid (.assignment-info-with-version
storm-cluster-state sid callback)})
- {sid nil})))
- (apply merge)
- (filter-val not-nil?))
+ (let [new-assignments (.assignments-info storm-cluster-state)
new-profiler-actions
(->>
(dofor [sid (distinct storm-ids)]
(if-let [topo-profile-actions
(.get-topology-profile-requests storm-cluster-state sid false)]
{sid topo-profile-actions}))
(apply merge))]
- {:assignments (into {} (for [[k v] new-assignments] [k (:data v)]))
+ {:assignments new-assignments
:profiler-actions new-profiler-actions
+ ;; TODO: remove versions
--- End diff --
Are you going to remove the TODO or not?
---
