Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2319#discussion_r138073996
  
    --- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
    @@ -590,6 +583,7 @@
                                     (set (keys new-assignment)))]
             (.killedWorker isupervisor (int p)))
           (.assigned isupervisor (keys new-assignment))
    +      ;;TODO: remove one copy of assignmnets.
    --- End diff --
    
    All of the TODO comments need to be removed.  If you want to do them, then 
either do them or file a follow on JIRA to do them.


---

Reply via email to