Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2385#discussion_r149162982
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/scheduler/TopologyDetails.java ---
    @@ -289,17 +300,13 @@ public Double getTotalMemReqTask(ExecutorDetails 
exec) {
     
         /**
          * Gets the total memory resource list for a set of tasks that is part 
of a topology.
    -     * @return Map<ExecutorDetails, Double> a map of the total memory 
requirement for all tasks in topology topoId.
    +     * @param executors
    --- End diff --
    
    nit Having a param with no explanation is not really helpful.


---

Reply via email to